Bug 40 - Destruction of ServerSubscription usages for NOTIFY failures is too generic
Summary: Destruction of ServerSubscription usages for NOTIFY failures is too generic
Status: NEW
Alias: None
Product: resiprocate
Classification: Unclassified
Component: dum (libdum) (show other bugs)
Version: unspecified
Hardware: All All
: P1 minor
Assignee: Owner of all unassigned bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 09:04 CDT by Francis Joanis
Modified: 2013-04-11 09:04 CDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francis Joanis 2013-04-11 09:04:08 CDT
In Dialog::dispatch, when processing a failure response for a NOTIFY, all ServerSubsriptions contained in mServerSubscriptions get destroyed.

This means that if a single dialog usage fails all the usages will be destroyed. This seems to be too broad against what is defined in RFC 5057.

The code should probably use Helper::determineFailureMessageEffect and then see if all usages need to be destroyed or only particular one(s).