Bug 46 - Stop using SipMessage to parse the WebSocket HTTP headers
Summary: Stop using SipMessage to parse the WebSocket HTTP headers
Status: NEW
Alias: None
Product: resiprocate
Classification: Unclassified
Component: stack (libresip) (show other bugs)
Version: unspecified
Hardware: All All
: P1 normal
Assignee: Owner of all unassigned bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 15:20 CDT by Daniel Pocock
Modified: 2013-09-28 15:20 CDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Pocock 2013-09-28 15:20:26 CDT
When a user connects over a WebSocket transport, the connection handling code uses SipMessage to parse the HTTP headers in the WebSocket upgrade request.

This works but it is not elegant and it means that certain HTTP headers relating to WebSockets and Cookies are now supported in the SipMessage class, even though such headers have no role in SIP itself.

A unified HTTP parsing solution should also be useful for improving the repro web interface, it currently has a very basic HTTP parser.