Bug 49 - resiprocate-1.8.11/resip/dum/ClientRegistration.cxx:276: bad if test ?
Summary: resiprocate-1.8.11/resip/dum/ClientRegistration.cxx:276: bad if test ?
Status: NEW
Alias: None
Product: resiprocate
Classification: Unclassified
Component: dum (libdum) (show other bugs)
Version: unspecified
Hardware: All Linux
: P1 normal
Assignee: Owner of all unassigned bugs
Depends on:
Reported: 2013-11-19 02:49 CST by David Binderman
Modified: 2013-11-19 02:49 CST (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2013-11-19 02:49:06 CST
I just recompiled resiprocate-1.8.11 with extra Linux gcc
compiler flag -Wlogical-op

It said

ClientRegistration.cxx:276:29: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

Source code is

ClientRegistration::internalRequestRefresh(UInt32 expires)
   if(mState == RetryAdding && mState == RetryRefreshing)

Suggest swap && for ||