Bug 56 - RADIUS: code needs a cleanup
Summary: RADIUS: code needs a cleanup
Status: NEW
Alias: None
Product: resiprocate
Classification: Unclassified
Component: rutil (librutil) (show other bugs)
Version: unspecified
Hardware: All All
: P1 normal
Assignee: Owner of all unassigned bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 12:40 CST by Daniel Pocock
Modified: 2013-12-31 12:40 CST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Pocock 2013-12-31 12:40:41 CST
There are several obvious issues:

- many calls to throw

- compiler warnings

RADIUSDigestAuthenticator.cxx:113:37: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]


- memory management using new/delete (could we use auto_ptr or SharedPtr?)


A proper refactoring would consider some of the bigger issues:

- event loop integration instead of using threads

- split the DIGEST-specific code out of the low level classes so they can be shared with HMAC for reTurn